[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=108654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108654
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 16:38
Start Date: 04/Jun/18 16:38
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5526: [BEAM-3773][SQL]
Init compiler factory with JDBC class loader
URL: https://github.com/apache/beam/pull/5526
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcIT.java
b/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcIT.java
index 08cd9a0a4d6..5f48e5111bc 100644
---
a/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcIT.java
+++
b/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcIT.java
@@ -17,6 +17,7 @@
*/
package org.apache.beam.sdk.extensions.sql.jdbc;
+import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import java.io.File;
@@ -50,4 +51,19 @@ public void classLoader_simple() throws Exception {
// SELECT 1 is a special case and does not reach the parser
assertTrue(statement.execute("SELECT 1"));
}
+
+ @Test
+ public void classLoader_parse() throws Exception {
+ Connection connection = getConnection();
+ Statement statement = connection.createStatement();
+ assertTrue(statement.execute("SELECT 'beam'"));
+ }
+
+ @Test
+ public void classLoader_ddl() throws Exception {
+ Connection connection = getConnection();
+ Statement statement = connection.createStatement();
+ assertEquals(0, statement.executeUpdate("CREATE TABLE test (id INTEGER)
TYPE 'text'"));
+ assertEquals(0, statement.executeUpdate("DROP TABLE test"));
+ }
}
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriver.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriver.java
index 9841a6b24bf..c8f95879011 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriver.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/JdbcDriver.java
@@ -17,6 +17,8 @@
*/
package org.apache.beam.sdk.extensions.sql.impl;
+import static
org.codehaus.commons.compiler.CompilerFactoryFactory.getDefaultCompilerFactory;
+
import java.sql.Connection;
import java.sql.SQLException;
import java.util.Properties;
@@ -37,6 +39,17 @@
private static final String BEAM_CALCITE_SCHEMA = "beamCalciteSchema";
static {
+ ClassLoader origLoader = Thread.currentThread().getContextClassLoader();
+ try {
+
Thread.currentThread().setContextClassLoader(JdbcDriver.class.getClassLoader());
+
+ // init the compiler factory using correct class loader
+ getDefaultCompilerFactory();
+ } catch (Exception e) {
+ throw new IllegalStateException(e);
+ } finally {
+ Thread.currentThread().setContextClassLoader(origLoader);
+ }
INSTANCE.register();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108654)
Time Spent: 11.5h (was: 11h 20m)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
