[
https://issues.apache.org/jira/browse/BEAM-4290?focusedWorklogId=108739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108739
]
ASF GitHub Bot logged work on BEAM-4290:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 20:53
Start Date: 04/Jun/18 20:53
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5489:
[BEAM-4290] proto changes to support staging_session_token
URL: https://github.com/apache/beam/pull/5489#discussion_r192510959
##########
File path:
runners/direct-java/src/test/java/org/apache/beam/runners/direct/portable/artifact/LocalFileSystemArtifactStagerServiceTest.java
##########
@@ -88,7 +88,11 @@ public void singleDataPutArtifactSucceeds() throws
Exception {
String name = "my-artifact";
requestObserver.onNext(
ArtifactApi.PutArtifactRequest.newBuilder()
-
.setMetadata(ArtifactApi.ArtifactMetadata.newBuilder().setName(name).build())
+ .setMetadata(
Review comment:
Not really. The LocalFileSystemArtifactStagerServiceTest does not use
StagingSessionToken so there is no need to verify at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 108739)
Time Spent: 6h 20m (was: 6h 10m)
> ArtifactStagingService that stages to a distributed filesystem
> --------------------------------------------------------------
>
> Key: BEAM-4290
> URL: https://issues.apache.org/jira/browse/BEAM-4290
> Project: Beam
> Issue Type: Sub-task
> Components: runner-core
> Reporter: Eugene Kirpichov
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Using the job's staging directory from PipelineOptions.
> Physical layout on the distributed filesystem is TBD but it should allow for
> arbitrary filenames and ideally for eventually avoiding uploading artifacts
> that are already there.
> Handling credentials is TBD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
