[
https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=108809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108809
]
ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/18 23:24
Start Date: 04/Jun/18 23:24
Worklog Time Spent: 10m
Work Description: wcn3 commented on a change in pull request #5507:
[BEAM-4276] Add combiner lifting support to Go SDK
URL: https://github.com/apache/beam/pull/5507#discussion_r192908195
##########
File path: sdks/go/pkg/beam/core/runtime/exec/combine_test.go
##########
@@ -148,7 +96,14 @@ func getCombineEdge(t *testing.T, cfn interface{}, ac
*coder.Coder) *graph.Multi
}
g := graph.New()
- inT := typex.NewCoGBK(typex.New(reflectx.Int), typex.New(reflectx.Int))
+ var vtype reflect.Type
+ if fn.AddInputFn() != nil {
+ // This makes the assumption that the AddInput function is
unkeyed.
Review comment:
Not sure what the impact of this comment is. Are AddInput functions supposed
to allow keys? That is, this comment indicates that the full contract is not
implemented? Or does it mean an AddInput function should always be unkeyed, but
we're not bothering to check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 108809)
Time Spent: 5h 50m (was: 5h 40m)
> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
> Key: BEAM-4276
> URL: https://issues.apache.org/jira/browse/BEAM-4276
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Specifically add the necessary code to produce a Combine Composite with the
> correct URN, and permit the SDK harness to understand the lifted parts when
> receiving a bundle plan from the worker.
> Not expected as part of this issue is:
> Additional performance tweaks to the in memory cache (See
> [BEAM-4468|https://issues.apache.org/jira/browse/BEAM-4468])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
