[ 
https://issues.apache.org/jira/browse/BEAM-3826?focusedWorklogId=108973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108973
 ]

ASF GitHub Bot logged work on BEAM-3826:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/18 08:18
            Start Date: 05/Jun/18 08:18
    Worklog Time Spent: 10m 
      Work Description: jasonkuster closed pull request #5473: [BEAM-3826] 
Tweak Go integration test driver
URL: https://github.com/apache/beam/pull/5473
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/go/test/integration/driver.go 
b/sdks/go/test/integration/driver.go
index 308be63ef71..18460afee12 100644
--- a/sdks/go/test/integration/driver.go
+++ b/sdks/go/test/integration/driver.go
@@ -31,8 +31,8 @@ import (
 )
 
 var (
-       cpus   = flag.Int("cpus", 10, "Number of tests to run in parallel")
-       filter = flag.String("filter", ".*", "Test filer to run a subset of 
tests")
+       parallel = flag.Int("parallel", 10, "Number of tests to run in 
parallel")
+       filter   = flag.String("filter", ".*", "Test filer to run a subset of 
tests")
 )
 
 const old_pond = "memfs://old_pond"
@@ -50,8 +50,8 @@ func main() {
        flag.Parse()
        beam.Init()
 
-       if *cpus < 1 {
-               *cpus = 1
+       if *parallel < 1 {
+               *parallel = 1
        }
 
        pipelines := []namedPipeline{
@@ -73,7 +73,7 @@ func main() {
 
        var failures int32
        var wg sync.WaitGroup
-       for i := 0; i < *cpus; i++ {
+       for i := 0; i < *parallel; i++ {
                wg.Add(1)
                go func() {
                        defer wg.Done()


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 108973)
    Time Spent: 3h  (was: 2h 50m)

> Complete Go SDK documentation
> -----------------------------
>
>                 Key: BEAM-3826
>                 URL: https://issues.apache.org/jira/browse/BEAM-3826
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> We need to add a Go QuickStart and development guides on the website. The 
> godoc should also be self-contained and published similarly to java and 
> python api docs.
> https://godoc.org/github.com/apache/beam/sdks/go/pkg/beam



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to