[
https://issues.apache.org/jira/browse/BEAM-4283?focusedWorklogId=109268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109268
]
ASF GitHub Bot logged work on BEAM-4283:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/18 01:21
Start Date: 06/Jun/18 01:21
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#5464: [BEAM-4283] Write Nexmark execution times to bigquery
URL: https://github.com/apache/beam/pull/5464#discussion_r193265905
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -1452,7 +1452,10 @@ static String getExtractDestinationUri(String
extractDestinationDir) {
}
@VisibleForTesting
- Write<T> withTestServices(BigQueryServices testServices) {
+ /**
+ * This method is for test usage only
+ */
+ public Write<T> withTestServices(BigQueryServices testServices) {
Review comment:
Yes. I assume "inject BigQueryServices to savePerfsToBigQuery()" is for
testing. BigQueryServicesImpl should not be public. I don't think there's a
point in making 'withTestServices' available for testing without making
'BigQueryServices' interface available. I think 'withTestServices' in
combination with FakeBigQueryServices will be useful for other Beam components
that need to test pipelines that write to BigQuery as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 109268)
> Export nexmark execution times to bigQuery
> ------------------------------------------
>
> Key: BEAM-4283
> URL: https://issues.apache.org/jira/browse/BEAM-4283
> Project: Beam
> Issue Type: Sub-task
> Components: examples-nexmark
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Nexmark only outputs the results collection to bigQuery and prints in the
> console the execution times. To supervise Nexmark execution times, we need to
> store them as well per runner/query/mode
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
