[
https://issues.apache.org/jira/browse/BEAM-4267?focusedWorklogId=109567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109567
]
ASF GitHub Bot logged work on BEAM-4267:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/18 22:15
Start Date: 06/Jun/18 22:15
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5573:
[BEAM-4267] Implement flink context factory methods
URL: https://github.com/apache/beam/pull/5573#discussion_r193576123
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkExecutableStageContext.java
##########
@@ -37,11 +43,18 @@
}
public static Factory batchFactory() {
- return null;
+ return jobInfo -> {
Review comment:
This "factory" should manage singleton state in this case. We want to make
sure there's only a single instance of a DockerJobBundleFactory for a given job
id. In order to do so, the factory itself needs to be a singleton.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 109567)
Time Spent: 2h 20m (was: 2h 10m)
> Implement a reusable library that can run an ExecutableStage with a given
> Environment
> -------------------------------------------------------------------------------------
>
> Key: BEAM-4267
> URL: https://issues.apache.org/jira/browse/BEAM-4267
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Axel Magnuson
> Assignee: Ben Sidhom
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Build off of the interfaces introduced in
> [BEAM-3327|https://github.com/apache/beam/pull/5152] to provide a reusable
> execution library to runners.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
