[
https://issues.apache.org/jira/browse/BEAM-2937?focusedWorklogId=109819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109819
]
ASF GitHub Bot logged work on BEAM-2937:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/18 18:02
Start Date: 07/Jun/18 18:02
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5536:
[BEAM-2937] Add Combine Grouped Values URN.
URL: https://github.com/apache/beam/pull/5536#discussion_r193839074
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -228,9 +228,9 @@ message StandardPTransforms {
// Payload: CombinePayload
COMBINE_GLOBALLY = 1 [(beam_urn) = "beam:transform:combine_globally:v1"];
- // Represents the Combine.groupedValues() operation.
- // If this is produced by an SDK, it is assumed that the SDK understands
- // each of CombineComponents.
+ // Represents the Combine Grouped Values transform, as described in the
+ // following document:
+ // https://s.apache.org/beam-runner-api-combine-model#heading=h.aj86ew4v1wk
Review comment:
Should this be moved from `Composites` to `CombineComponents`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 109819)
Time Spent: 2.5h (was: 2h 20m)
> Fn API combiner support w/ lifting to PGBK
> ------------------------------------------
>
> Key: BEAM-2937
> URL: https://issues.apache.org/jira/browse/BEAM-2937
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The FnAPI should support this optimization. Detailed design:
> https://s.apache.org/beam-runner-api-combine-model
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
