[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=109884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109884
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/18 22:05
Start Date: 07/Jun/18 22:05
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #5053: [BEAM-3981]
Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#issuecomment-395580375
Hmm. I am pretty sure my microbenchmark uses a Cython codepath since in
order for any code change to take effect I have to run `python setup.py
build_ext --inplace` to recompile associated C extensions. I checked once
again and I do see a 2x slowdown with `items()` once the size of the dictionary
goes more than 100000 elements. Here's code generated by Cython: a
https://docs.google.com/document/d/1S-oeqJGiMHt_L3iCgr9dYfQdR0_ukQE25mcvK-BqudU/edit#heading=h.drcukhvo4hd6.
Perhaps the slowdown is related to materializing the list of keys?
My microbenchmark setup is here:
https://github.com/apache/beam/compare/master...tvalentyn:coders_dict_microbencmark?expand=1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 109884)
Time Spent: 19h 40m (was: 19.5h)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Robbe
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 19h 40m
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
