[
https://issues.apache.org/jira/browse/BEAM-4388?focusedWorklogId=109893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109893
]
ASF GitHub Bot logged work on BEAM-4388:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/18 22:18
Start Date: 07/Jun/18 22:18
Worklog Time Spent: 10m
Work Description: XuMingmin commented on issue #5481: [BEAM-4388] Support
optimized logical plan
URL: https://github.com/apache/beam/pull/5481#issuecomment-395583612
there's a format error in new added lines, can you fix it?
```
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':beam-sdks-java-extensions-sql:spotlessJava'.
> The following files had format violations:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlExplainTest.java
@@ -28,80 +28,78 @@
import·org.junit.Before;
import·org.junit.Test;
-/**
-·*·UnitTest·for·{@link·BeamSqlParserImpl}.
-·*/
+/**·UnitTest·for·{@link·BeamSqlParserImpl}.·*/
public·class·BeamSqlExplainTest·{
-····private·InMemoryMetaStore·metaStore;
-····private·BeamSqlCli·cli;
+··private·InMemoryMetaStore·metaStore;
+··private·BeamSqlCli·cli;
-····@Before
-····public·void·setUp()·throws·SqlParseException,·RelConversionException,·ValidationException·{
-········metaStore·=·new·InMemoryMetaStore();
-········metaStore.registerProvider(new·TextTableProvider());
-········cli·=·new·BeamSqlCli().metaStore(metaStore);
+··@Before
+··public·void·setUp()·throws·SqlParseException,·RelConversionException,·ValidationException·{
+····metaStore·=·new·InMemoryMetaStore();
+····metaStore.registerProvider(new·TextTableProvider());
+····cli·=·new·BeamSqlCli().metaStore(metaStore);
-········cli.execute(
-················"create·table·person·(\n"
-························+·"id·int·COMMENT·'id',·\n"
-························+·"name·varchar·COMMENT·'name',·\n"
-························+·"age·int·COMMENT·'age')·\n"
-························+·"TYPE·'text'·\n"
-························+·"COMMENT·''·");
+····cli.execute(
+········"create·table·person·(\n"
+············+·"id·int·COMMENT·'id',·\n"
+············+·"name·varchar·COMMENT·'name',·\n"
+············+·"age·int·COMMENT·'age')·\n"
+············+·"TYPE·'text'·\n"
+············+·"COMMENT·''·");
-········cli.execute(
-················"create·table·A·(\n"
-························+·"c1·int·COMMENT·'c1',\n"
-························+·"c2·int·COMMENT·'c2')\n"
-························+·"TYPE·'text'\n"
-························+·"COMMENT·''·");
+····cli.execute(
+········"create·table·A·(\n"
+············+·"c1·int·COMMENT·'c1',\n"
... (95 more lines that didn't fit)
Run 'gradlew spotlessApply' to fix these violations.
* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option
to get more log output. Run with --scan to get full insights.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':beam-sdks-java-extensions-sql:checkstyleTest'.
> Checkstyle rule violations were found. See the report at:
file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_GradleBuild/src/sdks/java/extensions/sql/build/reports/checkstyle/test.html
Checkstyle files with violations: 1
Checkstyle violations by severity: [error:2]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 109893)
Time Spent: 2h 50m (was: 2h 40m)
> Support optimized logical plan
> ------------------------------
>
> Key: BEAM-4388
> URL: https://issues.apache.org/jira/browse/BEAM-4388
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kai Jiang
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Before converting into Beam Pipeline physical plan, logical plan should be
> optimized and it will be super helpful for efficiently executing Beam
> PTransforms pipeline.
> Calcite has two ways for optimizing logical plan (HepPlanner and
> VolcanoPlanner). We can support VolcanoPlanner first and apply calcite
> builtin optimize rules (like
> FilterJoinRule.FILTER_ON_JOIN) to sql query optimize plans.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
