[
https://issues.apache.org/jira/browse/BEAM-4519?focusedWorklogId=109916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-109916
]
ASF GitHub Bot logged work on BEAM-4519:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/18 23:05
Start Date: 07/Jun/18 23:05
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5582:
[BEAM-4519] Add staging_token to GetManifestRequest
URL: https://github.com/apache/beam/pull/5582#discussion_r193913479
##########
File path: model/job-management/src/main/proto/beam_artifact_api.proto
##########
@@ -81,7 +81,11 @@ message ProxyManifest {
}
// A request to get the manifest of a Job.
-message GetManifestRequest {}
+message GetManifestRequest {
+ // (Required) An opaque token representing the entirety of the staged
artifacts.
Review comment:
Also: this token should be in GetArtifactRequest as well - the token
basically identifies the job whose artifacts we're talking about.
I see in the other PR that you've been using the manifest itself for that,
but I don't think that's a good idea: in my view, the manifest contains
information about artifacts that's independent about how they're stored, e.g.
the artifact name in the manifest must NOT be a full path to the file on a
distributed filesystem, it must be the original name of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 109916)
Time Spent: 40m (was: 0.5h)
> Artifact Retrieval Service Protocol should be able to serve multiple
> Manifests.
> -------------------------------------------------------------------------------
>
> Key: BEAM-4519
> URL: https://issues.apache.org/jira/browse/BEAM-4519
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Axel Magnuson
> Assignee: Axel Magnuson
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The artifact staging service currently returns a staging_token that can be
> used as a key to access a manifest. However, the current protocol does not
> have a field that accepts this token.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
