[
https://issues.apache.org/jira/browse/BEAM-3905?focusedWorklogId=110094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-110094
]
ASF GitHub Bot logged work on BEAM-3905:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/18 12:34
Start Date: 08/Jun/18 12:34
Worklog Time Spent: 10m
Work Description: aljoscha commented on a change in pull request #5578:
[BEAM-3905] Update Flink Runner to Flink 1.5.0
URL: https://github.com/apache/beam/pull/5578#discussion_r194042581
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -396,20 +423,26 @@ public void close() throws Exception {
// in processWatermark*() but have holds, so we have to re-evaluate here.
processWatermark(new Watermark(Long.MAX_VALUE));
if (currentOutputWatermark < Long.MAX_VALUE) {
- throw new RuntimeException("There are still watermark holds. Watermark
held at "
- + keyedStateInternals.watermarkHold().getMillis() + ".");
+ if (keyedStateInternals == null) {
+ throw new RuntimeException("Current watermark is still " +
currentOutputWatermark + ".");
+
+ } else {
Review comment:
You mean flip the if?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 110094)
Time Spent: 2h 40m (was: 2.5h)
> Update Flink Runner to Flink 1.5.0
> ----------------------------------
>
> Key: BEAM-3905
> URL: https://issues.apache.org/jira/browse/BEAM-3905
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
