[
https://issues.apache.org/jira/browse/BEAM-4526?focusedWorklogId=111234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111234
]
ASF GitHub Bot logged work on BEAM-4526:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/18 19:32
Start Date: 12/Jun/18 19:32
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5597: [BEAM-4526]
Suppress immutability warning caused by LoadingCache in enum instance
URL: https://github.com/apache/beam/pull/5597#issuecomment-396707064
I'm just not a huge fan of using language constructs in this way, since enum
is an homage to lower-level languages where they are just primitive constants.
This might be the first time I disagree with Effective Java :-) but maybe I'm
just being curmudgeonly. I accept this as a new snazzy thing that might become
standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111234)
Time Spent: 1h (was: 50m)
> FlinkRunner failing errorprone due to mutable enum
> --------------------------------------------------
>
> Key: BEAM-4526
> URL: https://issues.apache.org/jira/browse/BEAM-4526
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Fix For: 2.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code}
> runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/BatchFlinkExecutableStageContext.java:77:
> warning: [ImmutableEnumChecker] enums should be immutable: 'BatchFactory'
> has field 'cachedContexts' of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>',
> the declaration of type
> 'com.google.common.cache.LoadingCache<org.apache.beam.runners.fnexecution.provisioning.JobInfo,org.apache.beam.runners.flink.translation.functions.BatchFlinkExecutableStageContext>'
> is not annotated with @com.google.errorprone.annotations.Immutable or
> @javax.annotation.concurrent.Immutable
> private final LoadingCache<JobInfo, BatchFlinkExecutableStageContext>
> cachedContexts;
> ^
> (see http://errorprone.info/bugpattern/ImmutableEnumChecker)
> error: warnings found and -Werror specified
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
