[ 
https://issues.apache.org/jira/browse/BEAM-4008?focusedWorklogId=111425&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111425
 ]

ASF GitHub Bot logged work on BEAM-4008:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jun/18 07:33
            Start Date: 13/Jun/18 07:33
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5336: 
[BEAM-4008] Futurize utils subpackage
URL: https://github.com/apache/beam/pull/5336#discussion_r194981003
 
 

 ##########
 File path: sdks/python/apache_beam/utils/windowed_value.py
 ##########
 @@ -178,34 +182,22 @@ def __repr__(self):
         self.windows,
         self.pane_info)
 
+  def _key(self):
+    return self.value, self.timestamp_micros, self.windows, self.pane_info
+
+  def __eq__(self, other):
+    return (type(self) == type(other)
+            and self.timestamp_micros == other.timestamp_micros
+            and self.value == self.value
 
 Review comment:
   No worries, thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 111425)
    Time Spent: 2h  (was: 1h 50m)

> Futurize and fix python 2 compatibility for utils subpackage
> ------------------------------------------------------------
>
>                 Key: BEAM-4008
>                 URL: https://issues.apache.org/jira/browse/BEAM-4008
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to