[
https://issues.apache.org/jira/browse/BEAM-3773?focusedWorklogId=111572&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111572
]
ASF GitHub Bot logged work on BEAM-3773:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/18 17:35
Start Date: 13/Jun/18 17:35
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5592:
[BEAM-3773] [SQL] Add support for setting PipelineOptions
URL: https://github.com/apache/beam/pull/5592#discussion_r195173101
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIOSourceRel.java
##########
@@ -29,11 +30,17 @@
/** BeamRelNode to replace a {@code TableScan} node. */
public class BeamIOSourceRel extends TableScan implements BeamRelNode {
- private BeamSqlTable sqlTable;
+ private final BeamSqlTable sqlTable;
+ private final Map<String, String> pipelineOptions;
Review comment:
That is basically what is done here. I think you are wondering how to get it
into `BeamSqlCli`? I'm out of the office today (and possibly tomorrow) but I'll
get that added to this PR.
I think you might like the JDBC interface we've been working on. It can run
queries like `BeamSqlCli` but can also give you output, for example row count
on INSERT INTO or actual rows on SELECT queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111572)
Time Spent: 16.5h (was: 16h 20m)
> [SQL] Investigate JDBC interface for Beam SQL
> ---------------------------------------------
>
> Key: BEAM-3773
> URL: https://issues.apache.org/jira/browse/BEAM-3773
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Anton Kedin
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 16.5h
> Remaining Estimate: 0h
>
> JDBC allows integration with a lot of third-party tools, e.g
> [Zeppelin|https://zeppelin.apache.org/docs/0.7.0/manual/interpreters.html],
> [sqlline|https://github.com/julianhyde/sqlline]. We should look into how
> feasible it is to implement a JDBC interface for Beam SQL
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
