ASF GitHub Bot logged work on BEAM-4481:

                Author: ASF GitHub Bot
            Created on: 13/Jun/18 17:48
            Start Date: 13/Jun/18 17:48
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5594: 
[BEAM-4481, BEAM-4484] Start vendoring portability dependencies to not have 
dependency conflicts
URL: https://github.com/apache/beam/pull/5594#discussion_r195176159

 File path: build_rules.gradle
 @@ -1253,6 +1254,125 @@ ext.applyGrpcNature = {
+ext.applyPortabilityNature = {
+  println "applyPortabilityNature with " + (it ? "$it" : "default 
configuration") + " for project $project.name"
+  applyJavaNature(enableFindbugs: false, enableErrorProne: false, 
shadowClosure: {
 Review comment:
   We have no control over the generated code so it seems silly to force it to 
a standard such as error prone/findbugs
   I tested this out right now and findbugs fails but error prone doesn't cause 
any warnings so if you really want the check, I'll swap.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 111579)
    Time Spent: 5.5h  (was: 5h 20m)

> Remove duplicate dependency declarations from runners/direct-java
> -----------------------------------------------------------------
>                 Key: BEAM-4481
>                 URL: https://issues.apache.org/jira/browse/BEAM-4481
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
> beam-model-pipeline and others are duplicated in the dependency list

This message was sent by Atlassian JIRA

Reply via email to