[
https://issues.apache.org/jira/browse/BEAM-4399?focusedWorklogId=111837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111837
]
ASF GitHub Bot logged work on BEAM-4399:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/18 11:41
Start Date: 14/Jun/18 11:41
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5632:
[BEAM-4399] Change CassandraIOIT to write-then-read
URL: https://github.com/apache/beam/pull/5632#discussion_r195374247
##########
File path:
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOIT.java
##########
@@ -70,159 +65,166 @@
@RunWith(JUnit4.class)
public class CassandraIOIT implements Serializable {
- private static IOTestPipelineOptions options;
+ /** CassandraIOIT options. */
+ public interface CassandraIOITOptions extends IOTestPipelineOptions {
+ /* Cassandra */
+ @org.apache.beam.sdk.options.Description("Host for Cassandra server (host
name/ip address)")
+ List<String> getCassandraHost();
Review comment:
If there's no suitable `@Default` for the host we can set this field as
`@Validation.Required`, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 111837)
> Change CassandraIOIT to write-then-read Performance Tests
> ---------------------------------------------------------
>
> Key: BEAM-4399
> URL: https://issues.apache.org/jira/browse/BEAM-4399
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CassandraIOIT is different than other IOITs (such as JdbcIOIT or MongodbIOIT)
> and does not fulfil the rules described in the documentation:
> [https://beam.apache.org/documentation/io/testing/#i-o-transform-integration-tests].
>
> We should make it coherent with other tests, more specifically:
> - write it in writeThenReadAll style
> - enable running it with Perfkit
> - provide Jenkins job to run it periodically
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
