[
https://issues.apache.org/jira/browse/BEAM-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512577#comment-16512577
]
Ardashir Motamed commented on BEAM-3218:
----------------------------------------
[~thang] that's a really good point, I think this should be designed to support
the other limits as well but the pr linked here is a good first start.
Personally, I'd avoid having static methods on PubsubIO and have a
configuration object passed into a public constructor for those limits
> Change PubsubBoundedWriter to check total byte size
> ---------------------------------------------------
>
> Key: BEAM-3218
> URL: https://issues.apache.org/jira/browse/BEAM-3218
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Thang Nguyen
> Assignee: Reuven Lax
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The PubsubBoundedWriter [does not
> check|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java#L895-L897]
> the total byte size of outgoing messages when publishing.
> AC:
> * Add a check to ensure the total bytes of the outgoing messages is less than
> pubsub's allowed max
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
