[
https://issues.apache.org/jira/browse/BEAM-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515403#comment-16515403
]
Cade Markegard edited comment on BEAM-4325 at 6/18/18 6:51 AM:
---------------------------------------------------------------
e.g. refactoring it to what ErrorProne recommends:
{code:java}
public <T> T opValueEvaluated(
Class<T> clazz, int idx, Row row, BoundedWindow window,
BeamSqlExpressionEnvironment env) {
return clazz.cast(op(idx).evaluate(row, window, env).getValue());
}{code}
I have issues for when it's casted to e.g.
{code:java}
Map<Object, Object> map = opValueEvaluated(<what should go here??>, 0,
inputRow, window, env);{code}
but for simple cases
{code:java}
Row dynamicRow = opValueEvaluated(Row.class, 0, inputRow, window, env);{code}
works fine.
Haven't spent the largest amount of time in a Java code base so any help here
would be great.
was (Author: cademarkegard):
e.g.
{code:java}
public <T> T opValueEvaluated(
Class<T> clazz, int idx, Row row, BoundedWindow window,
BeamSqlExpressionEnvironment env) {
return clazz.cast(op(idx).evaluate(row, window, env).getValue());
}{code}
I have issues for when it's casted to e.g.
{code:java}
Map<Object, Object> map = opValueEvaluated(<what should go here??>, 0,
inputRow, window, env);{code}
but for simple cases
{code:java}
Row dynamicRow = opValueEvaluated(Row.class, 0, inputRow, window, env);{code}
works fine.
Haven't spent the largest amount of time in a Java code base so any help here
would be great.
> Enforce ErrorProne analysis in the SQL project
> ----------------------------------------------
>
> Key: BEAM-4325
> URL: https://issues.apache.org/jira/browse/BEAM-4325
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Scott Wegner
> Assignee: Cade Markegard
> Priority: Minor
> Labels: errorprone, starter
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-extensions-sql}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-extensions-sql:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/extensions/sql}} project.
> # In {{sdks/java/extensions/sql/build.gradle}}, add {{failOnWarning: true}}
> to the call the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
