[
https://issues.apache.org/jira/browse/BEAM-3310?focusedWorklogId=112704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112704
]
ASF GitHub Bot logged work on BEAM-3310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/18 07:56
Start Date: 18/Jun/18 07:56
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #4548:
[BEAM-3310] Metrics pusher
URL: https://github.com/apache/beam/pull/4548#discussion_r195681772
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -120,7 +121,9 @@ public PipelineResult run(Pipeline pipeline) {
if (result instanceof DetachedEnvironment.DetachedJobExecutionResult) {
LOG.info("Pipeline submitted in Detached mode");
- return new FlinkDetachedRunnerResult();
+ FlinkDetachedRunnerResult flinkDetachedRunnerResult = new
FlinkDetachedRunnerResult();
+ // no metricsPusher because metrics are not supported in detached mode
Review comment:
I added this comment because of
https://github.com/apache/beam/blob/c0d902f9ba1307571c5b97fdf56765bb70e3e123/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkDetachedRunnerResult.java#L41
it means that metrics could not be requested from the PipelineResult in
detached mode because it is not available in detached mode.
The thing is that MetricsPusher does not use PipelineResult to extract
metrics but it uses it to know pipeline execution status to kill the extraction
thread. So basically, if I set up a MetricsPusher in detached mode I would not
be able to stop the thread leading to leaking thread.
As the whole Flink runner advertise not to support metrics in detached mode,
seems coherent to not support metrics extraction either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 112704)
Time Spent: 13h 10m (was: 13h)
> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>
> Key: BEAM-3310
> URL: https://issues.apache.org/jira/browse/BEAM-3310
> Project: Beam
> Issue Type: New Feature
> Components: runner-extensions-metrics, sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> The idea is to avoid relying on the runners to provide access to the metrics
> (either at the end of the pipeline or while it runs) because they don't have
> all the same capabilities towards metrics (e.g. spark runner configures sinks
> like csv, graphite or in memory sinks using the spark engine conf). The
> target is to push the metrics in the common runner code so that no matter the
> chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> https://lists.apache.org/thread.html/01a80d62f2df6b84bfa41f05e15fda900178f882877c294fed8be91e@%3Cdev.beam.apache.org%3E
> And the design doc:
> https://s.apache.org/runner_independent_metrics_extraction
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
