[ https://issues.apache.org/jira/browse/BEAM-3949?focusedWorklogId=112709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112709 ]
ASF GitHub Bot logged work on BEAM-3949: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Jun/18 09:57 Start Date: 18/Jun/18 09:57 Worklog Time Spent: 10m Work Description: kkucharc commented on a change in pull request #5434: [BEAM-3949] IOIT's setup() and teardown() db connection attempt sometimes fail resulting in test flakiness URL: https://github.com/apache/beam/pull/5434#discussion_r196023661 ########## File path: sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOITHelper.java ########## @@ -50,4 +52,46 @@ public static String getHashForRecordCount(int recordCount, Map<Integer, String> return PipelineOptionsValidator.validate(optionsType, options); } + + /** Interface for passing method to executeWithRetry method. */ + @FunctionalInterface + public interface RetryFunction { + void run() throws Exception; + } + + public static void executeWithRetry(RetryFunction function) throws Exception { + executeWithRetry(maxAttempts, minDelay, function); + } + + public static void executeWithRetry(int maxAttempts, long minDelay, RetryFunction function) + throws Exception { + ArrayList<Exception> errorList = new ArrayList<>(); + int attempts = 1; + long delay = minDelay; + + while (attempts <= maxAttempts) { + try { + function.run(); + return; + } catch (Exception e) { + LOG.warn("Attempt #{} of {} failed.", attempts, maxAttempts); + errorList.add(e); + if (attempts == maxAttempts) { + for (int i = 0; i < errorList.size(); i++) { + LOG.error( Review comment: Sure, I removed it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 112709) Time Spent: 8h (was: 7h 50m) > IOIT's setup() and teardown() db connection attempt sometimes fail resulting > in test flakiness > ---------------------------------------------------------------------------------------------- > > Key: BEAM-3949 > URL: https://issues.apache.org/jira/browse/BEAM-3949 > Project: Beam > Issue Type: Sub-task > Components: testing > Reporter: Łukasz Gajowy > Assignee: Kasia Kucharczyk > Priority: Major > Time Spent: 8h > Remaining Estimate: 0h > > setup() and teardown() methods sometimes have trouble connecting database in > Performance tests. It results in test flakiness. > Example logs: > [https://builds.apache.org/view/A-D/view/Beam/job/beam_PerformanceTests_HadoopInputFormat/65/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)