[
https://issues.apache.org/jira/browse/BEAM-4584?focusedWorklogId=112991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112991
]
ASF GitHub Bot logged work on BEAM-4584:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 03:37
Start Date: 19/Jun/18 03:37
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5683:
[BEAM-4584] Migrate build_rules.gradle to buildSrc plugin
URL: https://github.com/apache/beam/pull/5683
This is a direct move of the code from `build_rules.gradle` to a binary
plugin in the `buildSrc` directory. A proxy `build_rules.gradle` is left in
place, but should be migrated away from on a module-by-module basis.
I deliberately did not do anything to refactor the logic. Making this a
plugin might make it more natural to do refactors later. Personally, I think
each "nature" is probably a natural choice for a separate plugin, and it should
be very straightforward to do that.
NOTE: All I did was ensure that `./gradlew build` ran. The only failure I
saw was a py3 lint failure so I think the basics are ready. I didn't yet run
the publishing bits that are hidden behind conditionals. Those likely still
need some `project.` added, etc. Just putting this up for early review.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
R: @lukecwik
CC: @yifanzou @alanmyrvold @pabloem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 112991)
Time Spent: 10m
Remaining Estimate: 0h
> Use a "binary plugin" in buildSrc instead of "script plugin" in
> build_rules.gradle
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4584
> URL: https://issues.apache.org/jira/browse/BEAM-4584
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a best practice recommended by the Gradle documentation. It is
> expected to speed things up, and makes dependency management and testing
> slightly better.
> In terms of code, it is not much different, though some things that were
> previously implicit in the top-level groovy DSL will need to be made explicit
> in the plugin definition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
