[
https://issues.apache.org/jira/browse/BEAM-3314?focusedWorklogId=113132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113132
]
ASF GitHub Bot logged work on BEAM-3314:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 11:19
Start Date: 19/Jun/18 11:19
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #4228: BEAM-3314 Endpoint
host port configuration reset issue
URL: https://github.com/apache/beam/pull/4228#issuecomment-398364287
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 113132)
Time Spent: 2h 20m (was: 2h 10m)
> RedisIO: RedisConnectionConfiguration withEndpoint does not set host
> correctly.
> -------------------------------------------------------------------------------
>
> Key: BEAM-3314
> URL: https://issues.apache.org/jira/browse/BEAM-3314
> Project: Beam
> Issue Type: Bug
> Components: io-java-redis
> Affects Versions: 2.2.0
> Reporter: Vinay varma
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> {code:java}
> public Read withEndpoint(String host, int port) {
> checkArgument(host != null, "host can not be null");
> checkArgument(port > 0, "port can not be negative or 0");
> return builder()
>
> .setConnectionConfiguration(connectionConfiguration().withHost(host))
>
> .setConnectionConfiguration(connectionConfiguration().withPort(port))
> .build();
> }
> {code}
> think because setConnectionConfiguration sets the object back into the
> builder, the second set was overwriting the effects of setting the host.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
