[
https://issues.apache.org/jira/browse/BEAM-4575?focusedWorklogId=113345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113345
]
ASF GitHub Bot logged work on BEAM-4575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 19:57
Start Date: 19/Jun/18 19:57
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #5673:
[BEAM-4575] Cleanly transform graph from Calcite to Beam SQL
URL: https://github.com/apache/beam/pull/5673#discussion_r196557703
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -102,10 +102,9 @@ public void registerUdaf(String functionName,
Combine.CombineFn combineFn) {
defaultSchema.add(functionName, new UdafImpl(combineFn));
}
- public PTransform<PCollectionTuple, PCollection<Row>> parseQuery(String
query)
- throws ParseException {
+ public PCollection<Row> parseQuery(Pipeline pipeline, String query) throws
ParseException {
try {
- return planner.convertToBeamRel(query).toPTransform();
+ return BeamSqlRelUtils.toPCollection(pipeline,
planner.convertToBeamRel(query));
Review comment:
Yes, I meant BeamSqlEnv.parseQuery(). My GitHub highlighting skills are bad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 113345)
Time Spent: 2h 10m (was: 2h)
> Beam SQL should cleanly transform graph from Calcite
> ----------------------------------------------------
>
> Key: BEAM-4575
> URL: https://issues.apache.org/jira/browse/BEAM-4575
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would be nice if the Beam graph matched the Calcite graph in structure
> with each node generating a PTransform that is applied onto the PCollection
> of it's parent. We should also ensure that each Calcite node only appears in
> the Beam graph one time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
