[
https://issues.apache.org/jira/browse/BEAM-4575?focusedWorklogId=113406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113406
]
ASF GitHub Bot logged work on BEAM-4575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jun/18 22:03
Start Date: 19/Jun/18 22:03
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5687:
[BEAM-4575][SQL] Don't wait on Unbounded PCollections
URL: https://github.com/apache/beam/pull/5687#discussion_r196593309
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
##########
@@ -102,15 +107,37 @@ public Result implement(EnumerableRelImplementor
implementor, Prefer prefer) {
}
}
- private static PipelineResult run(
+ private static @Nullable PipelineResult run(
PipelineOptions options, BeamRelNode node, DoFn<Row, Void> doFn) {
Pipeline pipeline = Pipeline.create(options);
PCollectionTuple.empty(pipeline).apply(node.toPTransform()).apply(ParDo.of(doFn));
PipelineResult result = pipeline.run();
+
+ if (containsUnboundedPCollection(pipeline)) {
+ return null;
Review comment:
pipelineResult.getState doesn't communicate if a pipeline is expected to
terminate. It has the same problems as null. I've eliminated the common run
function so I will have access to everything I need to make the right decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 113406)
Time Spent: 3h 50m (was: 3h 40m)
> Beam SQL should cleanly transform graph from Calcite
> ----------------------------------------------------
>
> Key: BEAM-4575
> URL: https://issues.apache.org/jira/browse/BEAM-4575
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> It would be nice if the Beam graph matched the Calcite graph in structure
> with each node generating a PTransform that is applied onto the PCollection
> of it's parent. We should also ensure that each Calcite node only appears in
> the Beam graph one time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
