[
https://issues.apache.org/jira/browse/BEAM-4584?focusedWorklogId=113860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113860
]
ASF GitHub Bot logged work on BEAM-4584:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/18 18:23
Start Date: 20/Jun/18 18:23
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5683: [BEAM-4584] Migrate build_rules.gradle to buildSrc plugin
URL: https://github.com/apache/beam/pull/5683#discussion_r196894352
##########
File path: buildSrc/build.gradle
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Plugins for configuring _this build_ of the module
+plugins {
+ id 'groovy'
Review comment:
Agreed. Gross. Done. Noting that this is all autoformat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 113860)
Time Spent: 3.5h (was: 3h 20m)
> Use a "binary plugin" in buildSrc instead of "script plugin" in
> build_rules.gradle
> ----------------------------------------------------------------------------------
>
> Key: BEAM-4584
> URL: https://issues.apache.org/jira/browse/BEAM-4584
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> This is a best practice recommended by the Gradle documentation. It is
> expected to speed things up, and makes dependency management and testing
> slightly better.
> In terms of code, it is not much different, though some things that were
> previously implicit in the top-level groovy DSL will need to be made explicit
> in the plugin definition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
