[
https://issues.apache.org/jira/browse/BEAM-4559?focusedWorklogId=113927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113927
]
ASF GitHub Bot logged work on BEAM-4559:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/18 20:53
Start Date: 20/Jun/18 20:53
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5698: [BEAM-4559] Split post-commit jobs into automatically triggered and
ghprb phrase triggered
URL: https://github.com/apache/beam/pull/5698#discussion_r196938228
##########
File path: .test-infra/jenkins/JobBuilder.groovy
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import common_job_properties as cjp
+
+/**
+ * This class is to be used for defining jobs for post- and pre-commit tests.
+ *
+ * Purpose of this class is to define common strategies and reporting/building
paramereters
+ * for pre- and post- commit test jobs and unify them across the project.
+ */
+class JobBuilder {
+ private def scope;
+ private def jobDefinition;
+ private def job;
+
+ private JobBuilder(scope, jobDefinition = {}) {
+ this.scope = scope
+ this.jobDefinition = jobDefinition
+ this.job = null
+ }
+
+ static void postCommitJob(nameBase,
Review comment:
With this number of arguments, consider named arguments:
http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments
(it is a bit funky)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 113927)
Time Spent: 50m (was: 40m)
> Post-Commit tests stability
> ---------------------------
>
> Key: BEAM-4559
> URL: https://issues.apache.org/jira/browse/BEAM-4559
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [https://docs.google.com/document/d/1sczGwnCvdHiboVajGVdnZL0rfnr7ViXXAebBAf_uQME/edit#heading=h.t71pj6h7rd0w]
> Follow up on design doc specified above and implement required code work.
> * Split existing post-commit tests jobs to automatically and manually
> triggered
> * Add tracking by JIRA bugs for failing test job
> * Create document describing post-commit failures handling policies
> * Add tests status badge to PR template
> * Create dashboard for post-commit tests
> * Detect and fix flaky java tests
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
