[
https://issues.apache.org/jira/browse/BEAM-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518773#comment-16518773
]
Udi Meiri commented on BEAM-4606:
---------------------------------
A quick search yields that the versioning of pytz [tracks the IANA timezone
database|https://www.carsonlam.ca/python-pytz-versioning/].
Thus there is no concept of major version for pytz, AFAICT.
We currently only use pytz.utc in two places in this file:
https://github.com/apache/beam/blob/375bd3a6a53ba3ba7c965278dcb322875e1b4dca/sdks/python/apache_beam/utils/timestamp.py#L85
I don't think we care about keeping the database up to date for this use case.
so I am fine with pinning to a single version (such as ==2018.3).
> Upper bound for pytz dependency
> -------------------------------
>
> Key: BEAM-4606
> URL: https://issues.apache.org/jira/browse/BEAM-4606
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ahmet Altay
> Assignee: Udi Meiri
> Priority: Major
>
> Do we need an upper bound for the pytz dependency?
> ([https://github.com/apache/beam/blob/release-2.5.0/sdks/python/setup.py#L108)]
> We typically have upper bounds, in order to avoid future breakages due to a
> possibility of breaking/backward incompatible change of that depepdency.
> Good practice is to upper bound either at known version, or next major
> version. Do we need an exception for pytz because it does not seem to be
> following semantic versioning?
> cc: [~yifanzou] Is this something dependency notifier can warn on? Dependency
> without upper version bounds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
