[
https://issues.apache.org/jira/browse/BEAM-4618?focusedWorklogId=114756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-114756
]
ASF GitHub Bot logged work on BEAM-4618:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/18 13:00
Start Date: 22/Jun/18 13:00
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5732: [BEAM-4618] Fix
errors in BeamModulePlugin perf test section
URL: https://github.com/apache/beam/pull/5732
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 70ab9c3ff75..47dc8d98f03 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1077,22 +1077,22 @@ artifactId=${project.name}
/* include dependencies required by runners */
//if (runner?.contains('dataflow')) {
if (runner?.equalsIgnoreCase('dataflow')) {
- testCompile project(path:
":beam-runners-google-cloud-dataflow-java", configuration: 'shadowTest')
+ testCompile it.project(path:
":beam-runners-google-cloud-dataflow-java", configuration: 'shadowTest')
}
if (runner?.equalsIgnoreCase('direct')) {
- testCompile project(path: ":beam-runners-direct-java",
configuration: 'shadowTest')
+ testCompile it.project(path: ":beam-runners-direct-java",
configuration: 'shadowTest')
}
/* include dependencies required by filesystems */
if (filesystem?.equalsIgnoreCase('hdfs')) {
- testCompile project(path: ":beam-sdks-java-io-hadoop-file-system",
configuration: 'shadowTest')
- shadowTest library.java.hadoop_client
+ testCompile it.project(path:
":beam-sdks-java-io-hadoop-file-system", configuration: 'shadowTest')
+ shadowTest project.library.java.hadoop_client
}
/* include dependencies required by AWS S3 */
if (filesystem?.equalsIgnoreCase('s3')) {
- testCompile project(path: ":beam-sdks-java-io-amazon-web-services",
configuration: 'shadowTest')
+ testCompile it.project.project(path:
":beam-sdks-java-io-amazon-web-services", configuration: 'shadowTest')
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 114756)
Time Spent: 1h (was: 50m)
> Jenkins perf tests broken by gradle refactor
> --------------------------------------------
>
> Key: BEAM-4618
> URL: https://issues.apache.org/jira/browse/BEAM-4618
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The move from {{build_rules.gradle}} to
> {{buildSrc/.../BeamModulePlugin.groovy}} requires putting {{project.}} in
> front of a bunch of variables. The perf test code path was not tested, and is
> broken.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
