[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=115367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115367
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 09:18
Start Date: 25/Jun/18 09:18
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5738:
[BEAM-2855] Add Python Nexmark suite
URL: https://github.com/apache/beam/pull/5738#discussion_r197729375
##########
File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/query0.py
##########
@@ -0,0 +1,78 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Nexmark Query 0: Pass through (send and receive auction events)..
+
+The Nexmark suite is a series of queries (streaming pipelines) performed
+on a simulation of auction events. This query is a pass through that
+simply parses the events generated by the launcher. It serves as a test
+to verify the infrastructure.
+"""
+from __future__ import absolute_import
+from __future__ import print_function
+
+import csv
+import logging
+
+import apache_beam as beam
+from apache_beam.metrics.metric import Metrics
+from apache_beam.testing.benchmarks.nexmark.models import nexmark_model
+
+
+class ParseEventFn(beam.DoFn):
+ """Parses the raw event info into a Python objects.
+
+ Each event line has the following format:
+ person: <id starting with 'p'>,name,email,credit_card,city,
+ state,timestamp,extra
+ auction: <id starting with 'a'>,item_name, description,
+ initial_bid,reserve_price,timestamp,expires,seller,category,extra
+ bid: <auction starting with 'b'>,bidder,price,timestamp,extra
+
+ For example:
+ 'p12345,maria,[email protected],1234-5678-9012-3456,
+ sunnyvale,CA,1528098831536'
+ 'a12345,car,2012 hyundai elantra,20K,15K,
+ 1528098831536,20180630,maria,vehicle'
+ 'b12345,maria,354,1528098831536'
+ """
+
+ def __init__(self):
+ super(ParseEventFn, self).__init__()
+ self.num_parse_errors = Metrics.counter(self.__class__, 'num_parse_errors')
+
+ def process(self, elem):
+ row = list(csv.reader([elem]))[0]
+ if row[0].startswith('p'):
Review comment:
Hi, jumping in to comment some of the stuff we discussed offline and than
probably is not clear (partially my fault).
I think you should better use the 'real' data generated by the Java
generator (stored in PubSub) and try to implement a coder to decode the data in
python [by implementing the same logic that Java
does](https://github.com/apache/beam/blob/e77882c9cb2ed58cd408452462886d3022645813/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/model/Event.java#L88),
This way you don't use the comma separated csv (or these ifs) and we win
because we will get close to the real deal because [artificial
encoding/decoding is needed as part of
Query0](https://github.com/apache/beam/blob/e77882c9cb2ed58cd408452462886d3022645813/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/Query0.java#L54).
:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 115367)
Time Spent: 6h 50m (was: 6h 40m)
> Implement a python version of the nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark, sdk-py-core, testing
> Reporter: Ismaël Mejía
> Assignee: María GH
> Priority: Minor
> Labels: newbie, nexmark, starter
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
