[
https://issues.apache.org/jira/browse/BEAM-4602?focusedWorklogId=115444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115444
]
ASF GitHub Bot logged work on BEAM-4602:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 14:29
Start Date: 25/Jun/18 14:29
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#5749: [BEAM-4602][BEAM-4598] Datetime type comparison
URL: https://github.com/apache/beam/pull/5749#discussion_r197817604
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
##########
@@ -193,6 +193,29 @@ public void testThatOperatorsExist() {
}
}
+ @Test
+ @SqlOperatorTest(name = "<", kind = "LESS_THAN")
Review comment:
Can you leave these lines here, but comment them out? Here is why: when you
have an annotation like this it tells the framework that we already have enough
tests for this operator. It is great that you added some tests, but we should
get a whole suite for the other types too before we say we are done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 115444)
Time Spent: 20m (was: 10m)
> Implement Date Comparison in BeamSqlCompareExpression
> -----------------------------------------------------
>
> Key: BEAM-4602
> URL: https://issues.apache.org/jira/browse/BEAM-4602
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kai Jiang
> Assignee: Kai Jiang
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
