[
https://issues.apache.org/jira/browse/BEAM-4600?focusedWorklogId=115536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115536
]
ASF GitHub Bot logged work on BEAM-4600:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 17:15
Start Date: 25/Jun/18 17:15
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5746: [BEAM-4600]
adding logical operator tests
URL: https://github.com/apache/beam/pull/5746
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
index 9ea66899a89..916d9c1985a 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslSqlStdOperatorsTest.java
@@ -193,6 +193,53 @@ public void testThatOperatorsExist() {
}
}
+ @Test
+ @SqlOperatorTest(name = "OR", kind = "OR")
+ @SqlOperatorTest(name = "NOT", kind = "NOT")
+ @SqlOperatorTest(name = "AND", kind = "AND")
+ public void testLogicOperators() {
+ ExpressionChecker checker =
+ new ExpressionChecker()
+ .addExpr("1 = 1 AND 1 = 1", true)
+ .addExpr("1 = 1 OR 1 = 2", true)
+ .addExpr("NOT 1 = 2", true)
+ .addExpr("(NOT 1 = 2) AND (2 = 1 OR 3 = 3)", true)
+ .addExpr("2 = 2 AND 2 = 1", false)
+ .addExpr("1 = 2 OR 3 = 2", false)
+ .addExpr("NOT 1 = 1", false)
+ .addExpr("(NOT 2 = 2) AND (1 = 2 OR 2 = 3)", false)
+ .addExpr("'a' = 'a' AND 'a' = 'a'", true)
+ .addExpr("'a' = 'a' OR 'a' = 'b'", true)
+ .addExpr("NOT 'a' = 'b'", true)
+ .addExpr("(NOT 'a' = 'b') AND ('b' = 'a' OR 'c' = 'c')", true)
+ .addExpr("'b' = 'b' AND 'b' = 'a'", false)
+ .addExpr("'a' = 'b' OR 'c' = 'b'", false)
+ .addExpr("NOT 'a' = 'a'", false)
+ .addExpr("(NOT 'b' = 'b') AND ('a' = 'b' OR 'b' = 'c')", false)
+ .addExpr("1.0 = 1.0 AND 1.0 = 1.0", true)
+ .addExpr("1.0 = 1.0 OR 1.0 = 2.0", true)
+ .addExpr("NOT 1.0 = 2.0", true)
+ .addExpr("(NOT 1.0 = 2.0) AND (2.0 = 1.0 OR 3.0 = 3.0)", true)
+ .addExpr("2.0 = 2.0 AND 2.0 = 1.0", false)
+ .addExpr("1.0 = 2.0 OR 3.0 = 2.0", false)
+ .addExpr("NOT 1.0 = 1.0", false)
+ .addExpr("(NOT 2.0 = 2.0) AND (1.0 = 2.0 OR 2.0 = 3.0)", false)
+ .addExpr("NOT true", false)
+ .addExpr("NOT false", true)
+ .addExpr("true AND true", true)
+ .addExpr("true AND false", false)
+ .addExpr("false AND false", false)
+ .addExpr("true OR true", true)
+ .addExpr("true OR false", true)
+ .addExpr("false OR false", false)
+ .addExpr("(NOT false) AND (true OR false)", true)
+ .addExpr("(NOT true) AND (true OR false)", false)
+ .addExpr("(NOT false) OR (true and false)", true)
+ .addExpr("(NOT true) OR (true and false)", false);
+
+ checker.buildRunAndCheck();
+ }
+
@Test
@SqlOperatorTest(name = "CHARACTER_LENGTH", kind = "OTHER_FUNCTION")
@SqlOperatorTest(name = "CHAR_LENGTH", kind = "OTHER_FUNCTION")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 115536)
Time Spent: 40m (was: 0.5h)
> Test logical operators at the DSL level
> ---------------------------------------
>
> Key: BEAM-4600
> URL: https://issues.apache.org/jira/browse/BEAM-4600
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
