[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=115663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115663
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 21:46
Start Date: 25/Jun/18 21:46
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5566:
[BEAM-2939, BEAM-3743, BEAM-3833] Supports SDF in Reference Runner
URL: https://github.com/apache/beam/pull/5566#discussion_r197912929
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/ReferenceRunner.java
##########
@@ -315,6 +322,128 @@ public MessageWithComponents getReplacement(String
gbkId, ComponentsOrBuilder co
}
}
+ @VisibleForTesting
+ static class SplittableProcessKeyedReplacer implements TransformReplacement {
+ @Override
+ public MessageWithComponents getReplacement(String spkId,
ComponentsOrBuilder components) {
+ PTransform spk = components.getTransformsOrThrow(spkId);
+ checkArgument(
+
PTransformTranslation.SPLITTABLE_PROCESS_KEYED_URN.equals(spk.getSpec().getUrn()),
+ "URN must be %s, got %s",
+ PTransformTranslation.SPLITTABLE_PROCESS_KEYED_URN,
+ spk.getSpec().getUrn());
+
+ Components.Builder newComponents = Components.newBuilder();
+ newComponents.putAllCoders(components.getCodersMap());
+
+ Builder newPTransform = spk.toBuilder();
+
+ String inputId = getOnlyElement(spk.getInputsMap().values());
+ PCollection input = components.getPcollectionsOrThrow(inputId);
+
+ // This is a Coder<KV<String, KV<ElementT, RestrictionT>>>
Review comment:
(done in previous round)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 115663)
Time Spent: 2h 40m (was: 2.5h)
> Fn API streaming SDF support
> ----------------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Eugene Kirpichov
> Priority: Major
> Labels: portability
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
