[
https://issues.apache.org/jira/browse/BEAM-4613?focusedWorklogId=115693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115693
]
ASF GitHub Bot logged work on BEAM-4613:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 22:48
Start Date: 25/Jun/18 22:48
Worklog Time Spent: 10m
Work Description: huygaa11 commented on a change in pull request #5723:
[BEAM-4613] Use ByteBuddy to generate a coder class for a specific Schema.
URL: https://github.com/apache/beam/pull/5723#discussion_r197890012
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
##########
@@ -545,7 +551,8 @@ private Instant verifyDateTime(Object value, String
fieldName) {
public Row build() {
checkNotNull(schema);
- return new AutoValue_Row(verify(schema, values), schema);
+ List<Object> values = attached ? this.values : verify(schema,
this.values);
Review comment:
From the PR description, I see that attached values do not need
verification. However, I am not sure if that is always true, or at least it is
not documented within the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 115693)
Time Spent: 40m (was: 0.5h)
> Improve performance of SchemaCoder
> ----------------------------------
>
> Key: BEAM-4613
> URL: https://issues.apache.org/jira/browse/BEAM-4613
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
