[ 
https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=116041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116041
 ]

ASF GitHub Bot logged work on BEAM-3900:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jun/18 17:15
            Start Date: 26/Jun/18 17:15
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5735: 
[BEAM-3900] Improvements in Metrics translation, composite transforms, tests 
and windowing API.
URL: https://github.com/apache/beam/pull/5735#discussion_r198227995
 
 

 ##########
 File path: sdks/java/extensions/euphoria/euphoria-core/build.gradle
 ##########
 @@ -21,10 +21,31 @@ applyJavaNature(enableFindbugs: false)
 
 description = "Apache Beam :: SDKs :: Java :: Extensions :: Euphoria Java 8 
DSL :: Core"
 
+ext {
+    kryoVersion = '2.24.0'
+}
+
 dependencies {
+    shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
+    compile "com.esotericsoftware.kryo:kryo:${kryoVersion}"
     shadow library.java.guava
-    shadow library.java.slf4j_api
     compileOnly library.java.findbugs_jsr305
     testCompile library.java.mockito_core
     testCompile project(path: ':beam-sdks-java-extensions-euphoria-testing')
-}
\ No newline at end of file
+    shadow 'com.google.code.findbugs:annotations:3.0.+'
+    testCompile library.java.slf4j_api
+    testCompile library.java.hamcrest_core
+    testCompile library.java.slf4j_simple
+    testCompile library.java.mockito_core
+    testCompile project(path: ":beam-sdks-java-core", configuration: 
"testArtifact")
 
 Review comment:
   You should be relying on the `shadowTest` configuration and not 
`testArtifact`.
   
   This will remove the need for you to define the `testArtifact` in 
`sdks/java/core`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 116041)
    Time Spent: 50m  (was: 40m)

> Introduce Euphoria Java 8 DSL
> -----------------------------
>
>                 Key: BEAM-3900
>                 URL: https://issues.apache.org/jira/browse/BEAM-3900
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-euphoria
>            Reporter: David Moravek
>            Assignee: David Moravek
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is the umbrella issue for integrating [Euphoria 
> API|http://github.com/seznam/euphoria] into Beam.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to