[
https://issues.apache.org/jira/browse/BEAM-4651?focusedWorklogId=116523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116523
]
ASF GitHub Bot logged work on BEAM-4651:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/18 18:33
Start Date: 27/Jun/18 18:33
Worklog Time Spent: 10m
Work Description: kennknowles closed pull request #5786: [BEAM-4651] Add
bundle-ready SQL shell using application plugin
URL: https://github.com/apache/beam/pull/5786
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/extensions/sql/shell/build.gradle
b/sdks/java/extensions/sql/shell/build.gradle
new file mode 100644
index 00000000000..74fc9734e44
--- /dev/null
+++ b/sdks/java/extensions/sql/shell/build.gradle
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: org.apache.beam.gradle.BeamModulePlugin
+
+apply plugin: "application"
+
+dependencies {
+ compile project(path: ":beam-sdks-java-extensions-sql-jdbc", configuration:
"shadow")
+
+ if (project.hasProperty("beam.sql.shell.bundled")) {
+ project.getProperty("beam.sql.shell.bundled").tokenize(",").each {
+ subproject -> compile project(path: subproject, configuration: "shadow")
+ }
+ }
+}
+
+processResources {
+ filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
+ 'beam.version': version,
+ ]
+}
+
+mainClassName = "org.apache.beam.sdk.extensions.sql.jdbc.BeamSqlLine"
diff --git a/settings.gradle b/settings.gradle
index 969400951ff..07ae1adead7 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -94,6 +94,8 @@ include "beam-sdks-java-extensions-sql"
project(":beam-sdks-java-extensions-sql").dir =
file("sdks/java/extensions/sql")
include "beam-sdks-java-extensions-sql-jdbc"
project(":beam-sdks-java-extensions-sql-jdbc").dir =
file("sdks/java/extensions/sql/jdbc")
+include "beam-sdks-java-extensions-sql-shell"
+project(":beam-sdks-java-extensions-sql-shell").dir =
file("sdks/java/extensions/sql/shell")
include "beam-sdks-java-fn-execution"
project(":beam-sdks-java-fn-execution").dir = file("sdks/java/fn-execution")
include "beam-sdks-java-harness"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116523)
Time Spent: 0.5h (was: 20m)
> Bundled Beam SQL shell build
> ----------------------------
>
> Key: BEAM-4651
> URL: https://issues.apache.org/jira/browse/BEAM-4651
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We don't have a brilliant way to distribute or launch using just downloaded
> jars, but it is useful anyhow to be able to quickly build a self-contained
> SQL shell. The Gradle application plugin does this really well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)