[
https://issues.apache.org/jira/browse/BEAM-4659?focusedWorklogId=116662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116662
]
ASF GitHub Bot logged work on BEAM-4659:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/18 23:21
Start Date: 27/Jun/18 23:21
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #5794:
[BEAM-4659] Add well known timer coder to Java SDK.
URL: https://github.com/apache/beam/pull/5794#discussion_r198667854
##########
File path:
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
##########
@@ -152,6 +152,20 @@ examples:
---
+coder:
+ urn: "beam:coder:timer:v1"
+ components: [{urn: "beam:coder:bytes:v1"}]
+examples:
+ "\0\0\0\0\0\0\0\0\u0003abc": {timestamp: -9223372036854775808, payload: abc}
+ "\x7fÿÿÿÿÿÿ\x01\u0003abc": {timestamp: -255, payload: abc}
+ "\x7fÿÿÿÿÿÿÿ\u0003abc": {timestamp: -1, payload: abc}
+ "\x80\0\0\0\0\0\0\0\u0003abc": {timestamp: 0, payload: abc}
+ "\x80\0\0\0\0\0\0\x01\u0003abc": {timestamp: 1, payload: abc}
+ "\x80\0\0\0\0\0\x01\0\u0003abc": {timestamp: 256, payload: abc}
+ "ÿÿÿÿÿÿÿÿ\u0003abc": {timestamp: 9223372036854775807, payload: abc}
+
+---
+
Review comment:
Out of curiosity, is there a specific reason to place this coder definition
here? I initially assumed the coders were sorted in alphabetical order, but it
seems to be arbitrary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116662)
Time Spent: 0.5h (was: 20m)
> Add well known timer coder for Java SDK
> ---------------------------------------
>
> Key: BEAM-4659
> URL: https://issues.apache.org/jira/browse/BEAM-4659
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Encoding is: [Instant, Payload]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
