Zhiheng Huang created BEAM-4667:
-----------------------------------

             Summary: Potential issue with QuantileStateCoder
                 Key: BEAM-4667
                 URL: https://issues.apache.org/jira/browse/BEAM-4667
             Project: Beam
          Issue Type: Bug
          Components: sdk-java-core
            Reporter: Zhiheng Huang
            Assignee: Kenneth Knowles


[https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L687]

The line above encodes the QuantileState buffers.size() as if it's numBuffers. 
This seems wrong since before buffers are full, buffers.size() is not equal to 
numBuffers. One thing I suspect will happen is that, if we serialize before 
buffer is full, it will effectively reduce the number of buffers we maintain 
after deserialization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to