[
https://issues.apache.org/jira/browse/BEAM-4394?focusedWorklogId=116757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116757
]
ASF GitHub Bot logged work on BEAM-4394:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/18 04:03
Start Date: 28/Jun/18 04:03
Worklog Time Spent: 10m
Work Description: swegner commented on issue #5797: [BEAM-4394] Spotless
Java everywhere
URL: https://github.com/apache/beam/pull/5797#issuecomment-400904101
Do you think this plugin will eventually replace checkstyle completely? From
glancing over their docs it seems pretty powerful and I can't wait to enable
for the webpage markdown.
If you think this will replace Checkstyle, would you mind filing a follow-up
JIRA to start migrating rules? And if you think we'll still need both, I think
it's still preferable to migrate the rules that we can, since this gives
auto-fixes and Checkstyle doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116757)
Time Spent: 1h (was: 50m)
> Consider enabling spotless java format throughout codebase
> ----------------------------------------------------------
>
> Key: BEAM-4394
> URL: https://issues.apache.org/jira/browse/BEAM-4394
> Project: Beam
> Issue Type: New Feature
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> "Spotless" can enforce - and automatically restore - automatic Java
> formatting. Whenever formatting is off, it tells a user the exact command to
> fix it.
> It isn't (just) about code layout, it is about automation. We have pretty
> strict style rules enforced by checkstyle. The most efficient way to fix up a
> file is with autoformat. But if the autoformat hits a bunch of irrelevant
> lines, that is annoying for a reviewer and obscures git blame.
> If we enforce autoformat all the time, then it makes sure that autoformatting
> a particular PR has minimal effects and is always safe to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
