[
https://issues.apache.org/jira/browse/BEAM-3746?focusedWorklogId=116875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116875
]
ASF GitHub Bot logged work on BEAM-3746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/18 16:25
Start Date: 28/Jun/18 16:25
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #5176: [BEAM-3746] Added
error message for using Count.globally() on non-global windows
URL: https://github.com/apache/beam/pull/5176#issuecomment-401093446
We have turned on autoformatting of the codebase, which causes small
conflicts across the board. You can probably safely rebase and just keep your
changes. Like this:
```
$ git rebase
... see some conflicts
$ git diff
... confirmed that the conflicts are just autoformatting
... so we can just keep our changes are do our own autoformat
$ git checkout --theirs --
$ git add -u
$ git rebase --continue
$ ./gradlew spotlessJavaApply
```
Please ping me if you run into any difficulty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116875)
Time Spent: 1h 10m (was: 1h)
> Count.globally should override getIncompatibleGlobalWindowErrorMessage to
> tell the user the usage that is currently only in javadoc
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3746
> URL: https://issues.apache.org/jira/browse/BEAM-3746
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: beginner, newbie, starter
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> https://beam.apache.org/documentation/sdks/javadoc/2.3.0/org/apache/beam/sdk/transforms/Count.html#globally--
> "Note: if the input collection uses a windowing strategy other than
> GlobalWindows, use Combine.globally(Count.<T>combineFn()).withoutDefaults()
> instead."
> But the actual crash a user gets is:
> "java.lang.IllegalStateException: Default values are not supported in
> Combine.globally() if the output PCollection is not windowed by
> GlobalWindows. Instead, use Combine.globally().withoutDefaults() to output an
> empty PCollection if the input PCollection is empty, or
> Combine.globally().asSingletonView() to get the default output of the
> CombineFn if the input PCollection is empty."
> There is a method that exists solely to make this actually useful, so we
> should use it!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
