[
https://issues.apache.org/jira/browse/BEAM-1589?focusedWorklogId=116883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116883
]
ASF GitHub Bot logged work on BEAM-1589:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/18 16:27
Start Date: 28/Jun/18 16:27
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #4482: [BEAM-1589]
Added @onWindowExpiration annotation.
URL: https://github.com/apache/beam/pull/4482#issuecomment-401093950
We have turned on autoformatting of the codebase, which causes small
conflicts across the board. You can probably safely rebase and just keep your
changes. Like this:
```
$ git rebase
... see some conflicts
$ git diff
... confirmed that the conflicts are just autoformatting
... so we can just keep our changes are do our own autoformat
$ git checkout --theirs --
$ git add -u
$ git rebase --continue
$ ./gradlew spotlessJavaApply
```
Please ping me if you run into any difficulty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 116883)
Time Spent: 40m (was: 0.5h)
> Add OnWindowExpiration method to Stateful DoFn
> ----------------------------------------------
>
> Key: BEAM-1589
> URL: https://issues.apache.org/jira/browse/BEAM-1589
> Project: Beam
> Issue Type: New Feature
> Components: runner-core, sdk-java-core
> Reporter: Jingsong Lee
> Assignee: Batkhuyag Batsaikhan
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> See BEAM-1517
> This allows the user to do some work before the state's garbage collection.
> It seems kind of annoying, but on the other hand forgetting to set a final
> timer to flush state is probably data loss most of the time.
> FlinkRunner does this work very simply, but other runners, such as
> DirectRunner, need to traverse all the states to do this, and maybe it's a
> little hard.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
