[
https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=117088&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117088
]
ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/18 22:29
Start Date: 28/Jun/18 22:29
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5817:
[BEAM-3883] Stage files in the portability runner.
URL: https://github.com/apache/beam/pull/5817#discussion_r199006382
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -107,16 +108,12 @@ def run_pipeline(self, pipeline):
beam_job_api_pb2.PrepareJobRequest(
job_name='job', pipeline=proto_pipeline))
if prepare_response.artifact_staging_endpoint.url:
- # Must commit something to get a retrieval token,
- # committing empty manifest for now.
- # TODO(BEAM-3883): Actually stage required files.
- artifact_service = beam_artifact_api_pb2_grpc.ArtifactStagingServiceStub(
Review comment:
The imports _grpc and _pb2 above are no longer used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 117088)
Time Spent: 19.5h (was: 19h 20m)
> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
> Key: BEAM-3883
> URL: https://issues.apache.org/jira/browse/BEAM-3883
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ben Sidhom
> Assignee: Ankur Goenka
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or
> dependencies when talking to the job API. Artifacts that need to be staged
> include the user code itself, any SDK components not included in the
> container image, and the list of Python packages that must be installed at
> runtime.
>
> Artifacts that are currently expected can be found in the harness boot code:
> [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
