[
https://issues.apache.org/jira/browse/BEAM-3519?focusedWorklogId=117103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117103
]
ASF GitHub Bot logged work on BEAM-3519:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/18 22:52
Start Date: 28/Jun/18 22:52
Worklog Time Spent: 10m
Work Description: chamikaramj closed pull request #4651:
[BEAM-3519][BEAM-3668] Shaded netty related dependencies of
google-cloud-platform module
URL: https://github.com/apache/beam/pull/4651
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/io/google-cloud-platform/build.gradle
b/sdks/java/io/google-cloud-platform/build.gradle
index 6c8a8980722..a36db63041a 100644
--- a/sdks/java/io/google-cloud-platform/build.gradle
+++ b/sdks/java/io/google-cloud-platform/build.gradle
@@ -76,3 +76,15 @@ dependencies {
testCompile library.java.junit
testCompile library.java.slf4j_jdk14
}
+
+// Shade dependencies.
+shadowJar {
+ dependencies {
+ include(dependency(library.java.grpc_netty))
+ include(dependency(library.java.netty_handler))
+ include(dependency(library.java.netty_tcnative_boringssl_static))
+ }
+ relocate "io.netty", getJavaRelocatedPath("io.netty")
+ relocate "io.grpc", getJavaRelocatedPath("io.grpc")
+ relocate "org.apache.tomcat", getJavaRelocatedPath("org.apache.tomcat")
+}
diff --git a/sdks/java/io/google-cloud-platform/pom.xml
b/sdks/java/io/google-cloud-platform/pom.xml
index 7aae03b90c7..616503edcd4 100644
--- a/sdks/java/io/google-cloud-platform/pom.xml
+++ b/sdks/java/io/google-cloud-platform/pom.xml
@@ -40,7 +40,42 @@
<executions>
<execution>
<id>bundle-and-repackage</id>
- <phase>none</phase>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <artifactSet>
+ <includes>
+ <include>io.netty:netty-handler:jar:</include>
+
<include>io.netty:netty-tcnative-boringssl-static:jar:</include>
+ <include>io.grpc:grpc-netty:jar:</include>
+ </includes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+ <pattern>io.grpc</pattern>
+ <!--suppress MavenModelInspection -->
+ <shadedPattern>
+ org.apache.beam.sdk.repackaged.io.grpc
+ </shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>io.netty</pattern>
+ <!--suppress MavenModelInspection -->
+ <shadedPattern>
+ org.apache.beam.sdk.repackaged.io.netty
+ </shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>org.apache.tomcat</pattern>
+ <!--suppress MavenModelInspection -->
+ <shadedPattern>
+ org.apache.beam.sdk.repackaged.org.apache.tomcat
+ </shadedPattern>
+ </relocation>
+ </relocations>
+ </configuration>
</execution>
</executions>
</plugin>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 117103)
Time Spent: 4h 40m (was: 4.5h)
> GCP IO exposes netty on its API surface, causing conflicts with runners
> -----------------------------------------------------------------------
>
> Key: BEAM-3519
> URL: https://issues.apache.org/jira/browse/BEAM-3519
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Ismaël Mejía
> Assignee: Chamikara Jayalath
> Priority: Critical
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Google Cloud Platform IOs module leaks netty this causes conflicts in
> particular with execution systems that use conflicting versions of such
> modules.
> For the case there is a dependency conflict with the Spark Runner version of
> netty, see: BEAM-3492
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
