[ 
https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=117247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117247
 ]

ASF GitHub Bot logged work on BEAM-3942:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/18 07:30
            Start Date: 29/Jun/18 07:30
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on a change in pull request #5812: 
[BEAM-3942] Remove mvn leftovers from jenkins IOIT job definitions
URL: https://github.com/apache/beam/pull/5812#discussion_r199075858
 
 

 ##########
 File path: .test-infra/jenkins/job_PerformanceTests_FileBasedIO_IT.groovy
 ##########
 @@ -129,16 +129,15 @@ private void 
create_filebasedio_performance_test_job(testConfiguration) {
         }
 
         def argMap = [
-                benchmarks               : 'beam_integration_benchmark',
-                beam_it_timeout          : '1200',
-                beam_it_profile          : 'io-it',
-                beam_prebuilt            : 'false',
-                beam_sdk                 : 'java',
-                beam_it_module           : 'sdks/java/io/file-based-io-tests',
-                beam_it_class            : testConfiguration.itClass,
-                beam_it_options          : 
common_job_properties.joinPipelineOptions(pipelineOptions),
-                beam_extra_mvn_properties: '["filesystem=gcs"]',
-                bigquery_table           : testConfiguration.bqTable,
+                benchmarks           : 'beam_integration_benchmark',
 
 Review comment:
   Minor question, is this reformatting automatic? I kind of dislike having 
everything aligned to colons but it seems this is common in groovy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 117247)
    Time Spent: 12.5h  (was: 12h 20m)

> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>
>                 Key: BEAM-3942
>                 URL: https://issues.apache.org/jira/browse/BEAM-3942
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 12.5h
>  Remaining Estimate: 0h
>
> This requires performing updates to PerfKitBenchmarker and Beam so that we 
> can execute performance tests using Gradle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to