[
https://issues.apache.org/jira/browse/BEAM-4445?focusedWorklogId=117500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117500
]
ASF GitHub Bot logged work on BEAM-4445:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/18 17:44
Start Date: 29/Jun/18 17:44
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5757:
[BEAM-4445] Split pre-commit tests into separate jobs based on trigger
condition.
URL: https://github.com/apache/beam/pull/5757#discussion_r199232972
##########
File path: .test-infra/jenkins/common_job_properties.groovy
##########
@@ -147,17 +150,20 @@ class common_job_properties {
if (onlyTriggerPhraseToggle) {
onlyTriggerPhrase()
}
+ if (!triggerPathPatterns.isEmpty()) {
+ includedRegions(triggerPathPatterns.join('\n'))
Review comment:
You can view the documentation via the Job DSL API viewer
[here](https://builds.apache.org/plugin/job-dsl/api-viewer/index.html#method/org.jenkinsci.plugins.ghprb.GhprbTrigger.includedRegions):
> Each inclusion uses regular expression pattern matching, and must be
separated by a new line. An empty list implies that everything is included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 117500)
Time Spent: 3h 40m (was: 3.5h)
> Filter pre-commit triggering based on touched files
> ---------------------------------------------------
>
> Key: BEAM-4445
> URL: https://issues.apache.org/jira/browse/BEAM-4445
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
> Labels: beam-site-automation-reliability
> Fix For: Not applicable
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> This is discussed in the [Beam-Site Automation
> Reliability|https://s.apache.org/beam-site-automation] design, under
> "Pre-Commit Job Filtering"
> The proposal is to filter pre-commit job triggered on PR's based on which
> files are touched. The impact is that most PRs will only run one set of
> relevant tests, rather than all three. This will decrease test overhead and
> the impact of flaky tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
