[
https://issues.apache.org/jira/browse/BEAM-3971?focusedWorklogId=117695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117695
]
ASF GitHub Bot logged work on BEAM-3971:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/18 00:20
Start Date: 30/Jun/18 00:20
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5833:
[BEAM-3971, BEAM-4284] Remove fromProto for Pipeline and PTransform translation.
URL: https://github.com/apache/beam/pull/5833#discussion_r199304209
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CombineTranslationTest.java
##########
@@ -179,6 +185,12 @@ public void leaveCompositeTransform(Node node) {
}
}
+ private static Coder<?> getAccumulatorCoder(
+ CombinePayload payload, RehydratedComponents components) throws
IOException {
Review comment:
Not something to necessarily change here, but do we still need
`RehydratedComponents` at this point? It depends how it's used in general, but
I suspect that using the components may be sufficient (in most cases).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 117695)
Time Spent: 5h 10m (was: 5h)
> Pipeline translation utilities should not use SDK construction classes
> ----------------------------------------------------------------------
>
> Key: BEAM-3971
> URL: https://issues.apache.org/jira/browse/BEAM-3971
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> In general, portable runners will require access to pipeline information not
> available in rehydrated pipelines while constructing physical plans.
> Translation utilities should operate directly on protos or on thin,
> information-preserving wrappers.
> The pipeline fusion utilities already operate on protos directly and can be
> used as an example of how this could be done.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
