[
https://issues.apache.org/jira/browse/BEAM-3761?focusedWorklogId=117870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117870
]
ASF GitHub Bot logged work on BEAM-3761:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/18 15:47
Start Date: 30/Jun/18 15:47
Worklog Time Spent: 10m
Work Description: cclauss edited a comment on issue #5843: [BEAM-3761]
Define cmp() in Python 3
URL: https://github.com/apache/beam/pull/5843#issuecomment-401548830
Agreed. When I thought about centralizing it but the three files are not
near each other in the hierarchy (io, testing, transforms) but I suppose we
could do something like __from apache_beam.utils.compat import cmp__ It also
stuck me as a bit weird (in legacy Python) to import a _builtin_ from another
file so that made the try/except block essential which in turn means that just
_one line per file_ is actually saved. I will make the change if that seems
like the best approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 117870)
Time Spent: 8h 50m (was: 8h 40m)
> Fix Python 3 cmp function
> -------------------------
>
> Key: BEAM-3761
> URL: https://issues.apache.org/jira/browse/BEAM-3761
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: holdenk
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> Various functions don't exist in Python 3 that did in python 2. This Jira is
> to fix the use of cmp (which often will involve rewriting __cmp__ as well).
>
> Note: there are existing PRs for basestring and unicode (
> [https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
> , [https://github.com/apache/beam/pull/4730] )
>
> Note once all of the missing names/functions are fixed we can enable F821 in
> falke8 python 3.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
