[
https://issues.apache.org/jira/browse/BEAM-4076?focusedWorklogId=117893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117893
]
ASF GitHub Bot logged work on BEAM-4076:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/18 18:32
Start Date: 30/Jun/18 18:32
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #5545: [BEAM-4076] Import
Schema branch into master
URL: https://github.com/apache/beam/pull/5545#issuecomment-401558495
More specifically what happened: it appear that the conflicting PR was
merged after regular tests had triggered for this PR but before I had
merged my PR. The fact that I made sure to run ValidatesRunner tests before
merging my PR ironically caused this, as it widened the window between
tests running and PR merging (since it took many hours to run the
ValidatesRunner tests).
I sent you https://github.com/apache/beam/pull/5845 to fix this.
On Sat, Jun 30, 2018 at 11:25 AM Reuven Lax <[email protected]> wrote:
> There is a compilation error, introduced by a conflict with
>
https://github.com/apache/beam/commit/34edbd5cc38c1eab0307569da518bceef325e696#diff-6f8f4b5d3d2bc0ef3cc57759b224bc36.Sending
> you a PR to fix this.
>
> On Sat, Jun 30, 2018 at 11:10 AM Reuven Lax <[email protected]> wrote:
>
>> Looking. I explicitly triggered a bunch of PostCommit tests before
>> merging this, so might have been one I missed.
>>
>> On Sat, Jun 30, 2018 at 11:03 AM Łukasz Gajowy <[email protected]>
>> wrote:
>>
>>> I'm afraid after merging this the build started breaking:
>>>
>>>
https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_GradleBuild/1002/console
>>>
>>> Better (more verbose) logs:
>>>
https://builds.apache.org/view/A-D/view/Beam/job/beam_PerformanceTests_XmlIOIT/453/console
>>>
>>> —
>>> You are receiving this because you modified the open/close state.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/beam/pull/5545#issuecomment-401556941>, or
mute
>>> the thread
>>>
<https://github.com/notifications/unsubscribe-auth/AUGE1cNgHhxaKPNnKFaLMBSFlHmCI4bOks5uB71ygaJpZM4UYOHO>
>>> .
>>>
>>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 117893)
Time Spent: 8h 50m (was: 8h 40m)
> Schema followups
> ----------------
>
> Key: BEAM-4076
> URL: https://issues.apache.org/jira/browse/BEAM-4076
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, dsl-sql, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> This umbrella bug contains subtasks with followups for Beam schemas, which
> were moved from SQL to the core Java SDK and made to be type-name-based
> rather than coder based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
