[
https://issues.apache.org/jira/browse/BEAM-4702?focusedWorklogId=118032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118032
]
ASF GitHub Bot logged work on BEAM-4702:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/18 03:23
Start Date: 02/Jul/18 03:23
Worklog Time Spent: 10m
Work Description: vectorijk commented on a change in pull request #5850:
[BEAM-4702] Re-window into global window after GROUP BY <window> plus a couple
other little fixes
URL: https://github.com/apache/beam/pull/5850#discussion_r199377962
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamAggregationTransforms.java
##########
@@ -185,6 +185,7 @@ public AggregationAdaptor(
aggregators.add(BeamBuiltinAggregations.createMin(call.type.getSqlTypeName()));
break;
case "SUM":
+ case "$SUM0":
Review comment:
I agree. Also, should we support a separated built-in `sum0` function in the
future? I think `sum` can't convert none element to zero automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 118032)
Time Spent: 40m (was: 0.5h)
> After SQL GROUP BY <windowing> the result should be globally windowed
> ---------------------------------------------------------------------
>
> Key: BEAM-4702
> URL: https://issues.apache.org/jira/browse/BEAM-4702
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
