[
https://issues.apache.org/jira/browse/BEAM-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kenneth Knowles updated BEAM-4704:
----------------------------------
Description:
{{TRIM}} is defined to trim _all_ the characters in the first string from the
string-to-be-trimmed. Calcite has an incorrect implementation of this. We use
our own fixed implementation. But when executed through the SQL shell, the
results do not match what we get from the PTransform path. Here two test cases
that pass on {{master}} but are incorrect in the shell:
{code:sql}
BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
+------------+
| EXPR$0 |
+------------+
| hehe__hehe |
+------------+
{code}
{code:sql}
BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
+------------+
| EXPR$0 |
+------------+
| hehe__heh |
+------------+
{code}
{code:sql}
BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
+------------+
| EXPR$0 |
+------------+
| hehe__heh |
+------------+
{code}
was:
{{TRIM}} is defined to trim _all_ the characters in the first string from the
string-to-be-trimmed. Calcite has an incorrect implementation of this. We use
our own fixed implementation. But when executed through the SQL shell, the
results do not match what we get from the PTransform path. Here are two test
cases that pass on {{master}} but are incorrect in the shell:
{code:java}
BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
+------------+
| EXPR$0 |
+------------+
| hehe__hehe |
+------------+
{code}
{code:java}
BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
+------------+
| EXPR$0 |
+------------+
| hehe__heh |
+------------+
{code}
> String operations yield incorrect results when executed through SQL shell
> -------------------------------------------------------------------------
>
> Key: BEAM-4704
> URL: https://issues.apache.org/jira/browse/BEAM-4704
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
>
> {{TRIM}} is defined to trim _all_ the characters in the first string from the
> string-to-be-trimmed. Calcite has an incorrect implementation of this. We use
> our own fixed implementation. But when executed through the SQL shell, the
> results do not match what we get from the PTransform path. Here two test
> cases that pass on {{master}} but are incorrect in the shell:
> {code:sql}
> BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__hehe |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__heh |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__heh |
> +------------+
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
