[
https://issues.apache.org/jira/browse/BEAM-3708?focusedWorklogId=118318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118318
]
ASF GitHub Bot logged work on BEAM-3708:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/18 18:06
Start Date: 02/Jul/18 18:06
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5795:
[BEAM-3708] Adding grouping table to Precombine step.
URL: https://github.com/apache/beam/pull/5795#discussion_r199577433
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/CombineRunnersTest.java
##########
@@ -93,6 +93,7 @@ public Integer extractOutput(Integer accum) {
private RunnerApi.PTransform pTransform;
private String inputPCollectionId;
private String outputPCollectionId;
+ private RunnerApi.Pipeline pProto;
Review comment:
nit: `pProto` -> `pipeline` or `pipelineProto`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118318)
Time Spent: 5h 20m (was: 5h 10m)
> Implement the portable lifted Combiner transforms in Java SDK
> -------------------------------------------------------------
>
> Key: BEAM-3708
> URL: https://issues.apache.org/jira/browse/BEAM-3708
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core, sdk-java-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Java SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
